Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add gateway udt and add allowed values #947

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Jan 23, 2025

Overview/Summary

Create UDT for virtual network gateway parameters and add allowed values. In particular, with the consolidation and migration of the SKUS to default to availability zones per https://learn.microsoft.com/en-us/azure/vpn-gateway/gateway-sku-consolidation

Related Issues/Work Items

Fixes AB#37804

This PR fixes/adds/changes/removes

  1. Adds UDT with allowed values
  2. Fix sample bicep module

Breaking Changes

Notice: Breaking Changes in Bicep Module Configuration

As part of the migration to user-defined types (UDTs) for properties within the parVpnGatewayConfig and parExpressRouteGatewayConfig parameters, the following breaking changes have been introduced:

1. Supported SKUs Limited to Availability Zones

The list of supported SKUs for VPN and ExpressRoute gateways now only includes those with availability zones. This change aligns with the consolidation and migration updates outlined in the official Azure documentation. For more details, refer to the Gateway SKU Consolidation and Migration Guide.

2. Property Name Alignment for parVpnGatewayConfig

The generation property in parVpnGatewayConfig has been renamed to vpnGatewayGeneration to align with the schema property name already used for parExpressRouteGatewayConfig.

3. Case Sensitivity of bgpSettings

The bgpsettings property is now case-sensitive and must be written as bgpSettings.

Subproperty Changes:
  • The asn and peerweight subproperties within bgpSettings now require integer values instead of strings, ensuring consistency with the resource schema.

Please update your configurations accordingly to avoid deployment errors.

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:05 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:08 — with GitHub Actions Waiting
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation January 23, 2025 23:08 — with GitHub Actions Inactive
@oZakari oZakari changed the title Add gateway udt and add allowed values refactor: Add gateway udt and add allowed values Jan 23, 2025
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:10 — with GitHub Actions Waiting
@oZakari oZakari added the Area: Networking 🌐 Issues / PR's related to Networking label Jan 23, 2025
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:20 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:21 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:21 — with GitHub Actions Waiting
@oZakari oZakari requested a review from sebassem January 23, 2025 23:22
@oZakari oZakari closed this Jan 23, 2025
@oZakari oZakari reopened this Jan 23, 2025
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation January 23, 2025 23:22 — with GitHub Actions Inactive
@oZakari oZakari added the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. label Jan 23, 2025
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation January 23, 2025 23:26 — with GitHub Actions Waiting
@azure-boards azure-boards bot temporarily deployed to BicepUpdateDocumentation January 23, 2025 23:26 Inactive
@oZakari
Copy link
Contributor Author

oZakari commented Jan 24, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant