Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gpu driver image to support h100s #3865

Merged
merged 4 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/agent/baker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1734,25 +1734,25 @@ var _ = Describe("Test normalizeResourceGroupNameForLabel", func() {

var _ = Describe("getGPUDriverVersion", func() {
It("should use 470 with nc v1", func() {
Expect(getGPUDriverVersion("standard_nc6")).To(Equal("cuda-470.82.01"))
Expect(getGPUDriverVersion("standard_nc6")).To(Equal(datamodel.Nvidia470CudaDriverVersion))
})
It("should use 525 cuda with nc v3", func() {
Expect(getGPUDriverVersion("standard_nc6_v3")).To(Equal("cuda-525.85.12"))
Expect(getGPUDriverVersion("standard_nc6_v3")).To(Equal(datamodel.Nvidia525CudaDriverVersion))
})
It("should use 535 grid with nv v5", func() {
Expect(getGPUDriverVersion("standard_nv6ads_a10_v5")).To(Equal("grid-535.54.03"))
Expect(getGPUDriverVersion("Standard_nv36adms_A10_V5")).To(Equal("grid-535.54.03"))
Expect(getGPUDriverVersion("standard_nv6ads_a10_v5")).To(Equal(datamodel.Nvidia535GridDriverVersion))
Expect(getGPUDriverVersion("Standard_nv36adms_A10_V5")).To(Equal(datamodel.Nvidia535GridDriverVersion))
})
It("should use 525 cuda with nv v1 (although we don't know if that works)", func() {
Expect(getGPUDriverVersion("standard_nv6")).To(Equal("cuda-525.85.12"))
Expect(getGPUDriverVersion("standard_nv6")).To(Equal(datamodel.Nvidia525CudaDriverVersion))
})
})

var _ = Describe("getAKSGPUImageSHA", func() {
It("should use newest AKSGPUGridSHA with nv v5", func() {
Expect(getAKSGPUImageSHA("standard_nv6ads_a10_v5")).To(Equal("sha-20ffa2"))
Expect(getAKSGPUImageSHA("standard_nv6ads_a10_v5")).To(Equal(datamodel.AKSGPUGridSHA))
})
It("should use newest AKSGPUCudaSHA with non grid SKU", func() {
Expect(getAKSGPUImageSHA("standard_nc6_v3")).To(Equal("sha-e8873b"))
Expect(getAKSGPUImageSHA("standard_nc6_v3")).To(Equal(datamodel.AKSGPUCudaSHA))
})
})
2 changes: 1 addition & 1 deletion pkg/agent/datamodel/const.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const (
// So for now these will be kept here like this.
const (
AKSGPUGridSHA = "sha-20ffa2"
AKSGPUCudaSHA = "sha-e8873b"
AKSGPUCudaSHA = "sha-16fd35"
)

/* ConvergedGPUDriverSizes : these sizes use a "converged" driver to support both cuda/grid workloads.
Expand Down
2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1604+Containerd/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1604+Docker/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1604+K8S115/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1604+K8S117/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1604+K8S118/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1804+HTTPProxy/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1804+NoneCNI/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu1804+krustlet/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu2204+China/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu2204+CustomCloud/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu2204+SSHStatusOff/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu2204+SSHStatusOn/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AKSUbuntu2204+cgroupv2/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/AzureLinuxV2+Kata/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/CustomizedImage/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/CustomizedImageKata/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/MarinerV2+Kata/CSECommand

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/RawUbuntu/CSECommand

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg/agent/testdata/RawUbuntuContainerd/CSECommand

Large diffs are not rendered by default.

Loading