Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-generate action workflow #4999

Closed
wants to merge 1 commit into from

Conversation

cameronmeissner
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11060596658

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.271%

Totals Coverage Status
Change from base Build 11059853467: 0.0%
Covered Lines: 2590
Relevant Lines: 3634

💛 - Coveralls

@cameronmeissner
Copy link
Collaborator Author

from further reading it seems that we can't utilize the GITHUB_TOKEN secret to make the auto-generated commit to the PR branch - that's due to the fact that commits made using GITHUB_TOKEN will not trigger CI jobs which would otherwise be triggered when the commit is made by a human author, which in our case would mostly likely cause problems since many of our CI workflows are considered required in all cases: https://github.com/orgs/community/discussions/25702#discussioncomment-3248819

to get around that limitation, we'd need to utilize a personal access token instead, which in and of itself brings it own challenges - at this point I'm not sure if we'd be able to use fine-grained access tokens or if we'd be forced to use classic access tokens. in either case, manually managing PATs is a cumbersome process and isn't really blessed by our current security posture.

further, my understanding is that in order for the workflow to be secure with respect to PRs potentially coming in from forks, we'd need to explicitly only allow it to be executed when being executed from this repository. in other words, the repo owner must be Azure: https://github.com/orgs/community/discussions/26409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants