Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add vhd content test for node ca watcher static tag #5049

Merged
merged 7 commits into from
Oct 10, 2024
Merged

test: add vhd content test for node ca watcher static tag #5049

merged 7 commits into from
Oct 10, 2024

Conversation

UtheMan
Copy link
Contributor

@UtheMan UtheMan commented Oct 9, 2024

What type of PR is this?
Adds vhd content test for static tag of node-ca-watcher image

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Oct 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11281377760

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.271%
Totals Coverage Status
Change from base Build 11281312341: 0.0%
Covered Lines: 2590
Relevant Lines: 3634
💛 - Coveralls

djsly
djsly reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@djsly djsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just sad about this Tagging to static concept... :(

@UtheMan UtheMan enabled auto-merge (squash) October 10, 2024 20:43
@UtheMan UtheMan disabled auto-merge October 10, 2024 21:52
@UtheMan
Copy link
Contributor Author

UtheMan commented Oct 10, 2024

Bypassing - build failing for some SKUs due to bcc tools, unrelated to test changes

@UtheMan UtheMan merged commit 0811432 into master Oct 10, 2024
15 of 18 checks passed
@UtheMan UtheMan deleted the mikolaj/add-custom-ca-image-test branch October 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsly djsly djsly approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UtheMan @coveralls @djsly