[node-bootstrapper] set ENV variables without intermediate template step #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2k1
requested review from
Devinwong,
lilypan26,
timmy-wright,
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly and
phealy
as code owners
|
Didn't look into cmd can set env before executing. This way is definitely better. Thanks for doing this. |
Devinwong
reviewed
Oct 29, 2024
| @@ -538,13 +501,13 @@ func getNBCInstance(jsonFilePath string) *nbcontractv1.Configuration { | |||
| return nBCB.GetNodeBootstrapConfig() | |||
| } | |||
|
|
|||
| func generateTestDataIfRequested(t *testing.T, folder, cseCmd string) { | |||
| func generateTestDataIfRequested(t *testing.T, folder string, cmd *exec.Cmd) { | |||
| if os.Getenv("GENERATE_TEST_DATA") == "true" { | |||
There was a problem hiding this comment.
Just seeing this so asking, though it's not part of this PR.
Where is this env var set? ADO pipeline?
There was a problem hiding this comment.
idk. It looks weird for me. I would delete it.
Devinwong
approved these changes
Oct 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the intermediate template step when setting environment variables in the
node-bootstrapperpackage.Type-safety is lost during templating.
This should reduce number of changes required to modify ENV variables and eliminate errors when a function string reference isn't updated after a code change (introduce type-safety).
It also moves us 1 step closer to shell script removal.