Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for customkubeletconfig on azure linux v2 #5183

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

bravebeaver
Copy link
Member

What type of PR is this?
/kind test

What this PR does / why we need it:

verify custom kubelet config are generated properly for kubelet on azure linux v2
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

should
Release note:

none

Copy link
Contributor

@r2k1 r2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Potentially you may create a helper function that accepts VHD.

kubeletConfigFilePath := "/etc/default/kubeletconfig.json"
RunScenario(t, &Scenario{
Tags: Tags{
KubeletCustomConfig: true,
Copy link
Contributor

@r2k1 r2k1 Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think we really need this tag.

@bravebeaver bravebeaver enabled auto-merge (squash) November 7, 2024 11:42
@bravebeaver bravebeaver merged commit e3df88e into dev Nov 7, 2024
11 of 12 checks passed
@bravebeaver bravebeaver deleted the beileih/seccompE2EAzureLinux branch November 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants