Rename node-bootstrapper => aks-node-controller #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2k1
requested review from
Devinwong,
lilypan26,
timmy-wright,
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly and
phealy
as code owners
vhdbuilder/packer/packer_source.sh
Outdated
| NODE_BOOTSTRAPPER_SERVICE_SRC=/home/packer/bootstrap.service | ||
| NODE_BOOTSTRAPPER_SERVICE_DEST=/etc/systemd/system/bootstrap.service | ||
| cpAndMode $NODE_BOOTSTRAPPER_SERVICE_SRC $NODE_BOOTSTRAPPER_SERVICE_DEST 0644 | ||
| AKS_NODE_CONTROLLER_SERVICE_SRC=/home/packer/bootstrap.service |
There was a problem hiding this comment.
im okay either way, but should we rename bootstrap.service to aks-node-controller.service as well?
There was a problem hiding this comment.
Makes sense. It's confused me before.
I think it's nice to make the relationship clear. It's unlikely we will need to change insides to another binary without renaming it.
cameronmeissner
approved these changes
Oct 31, 2024
lilypan26
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
node-bootstrapperbeen an interim name. We reached a consensus to rename it toaks-node-controllerto better reflect its purpose.