chore: cleanup + refactor for test infra migration #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sner/migration
cameronmeissner
changed the title
cameronmeissner
requested review from
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
r2k1
approved these changes
Nov 12, 2024
e2e/config/azure.go
Outdated
| @@ -208,7 +208,7 @@ func NewAzureClient(subscription string) (*AzureClient, error) { | |||
| return nil, fmt.Errorf("create vnet client: %w", err) | |||
| } | |||
|
|
|||
| cloud.GalleryImageVersion, err = armcompute.NewGalleryImageVersionsClient(subscription, credential, opts) | |||
| cloud.GalleryImageVersion, err = armcompute.NewGalleryImageVersionsClient(gallerySubscription, credential, opts) | |||
There was a problem hiding this comment.
I would just call Config.GallerySubscriptionID here. And do the same for subscription.
Devinwong
approved these changes
Nov 12, 2024
lilypan26
approved these changes
Nov 12, 2024
…sner/migration
cameronmeissner
added a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Cameron Meissner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
various cleanup + refactoring changes related to test infra migration
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: