Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dedicated pipeline variable to determine whether to publish VHD blobs #5277

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

cameronmeissner
Copy link
Collaborator

@cameronmeissner cameronmeissner commented Nov 15, 2024

What type of PR is this?

What this PR does / why we need it:

this PR does the following:

  • add a new pipeline variable GENERATE_PUBLISHING_INFO with different default values set on respective pipelines (default value for check-in pipeline + test-all pipeline is now false, official build pipeline default is true)
  • with this change, we no longer publish VHD blobs to a storage account unless running an official release, which is the only time we'd need to actually publish any blobs (packer will always publish to SIG, so we will maintain the ability to build VHDs for agentbaker e2e's in all pipelines)
  • DRY_RUN is preserved now as a pipeline variable, also with different default values based on the pipeline, this variable now only dictates whether to preserve the SIG image version packer generates as the build output
  • some other cleanup/renaming

TLDR - this change should drastically reduce storage costs by only having VHD blobs be published as a part of official builds, or if a dev explicitly overrides GENERATE_PUBLISHING_INFO via pipeline variables

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@cameronmeissner cameronmeissner changed the title chore: refactor DRY_RUN for creating VHD blobs chore: replace DRY_RUN with GENERATE_PUBLISHING_INFO, conditionally publish VHD blobs Nov 15, 2024
@cameronmeissner cameronmeissner changed the title chore: replace DRY_RUN with GENERATE_PUBLISHING_INFO, conditionally publish VHD blobs chore: add GENERATE_PUBLISHING_INFO pipeline variable to determine whether to publish VHD blobs Nov 15, 2024
@cameronmeissner cameronmeissner changed the title chore: add GENERATE_PUBLISHING_INFO pipeline variable to determine whether to publish VHD blobs feat: add GENERATE_PUBLISHING_INFO pipeline variable to determine whether to publish VHD blobs Nov 15, 2024
@cameronmeissner cameronmeissner changed the title feat: add GENERATE_PUBLISHING_INFO pipeline variable to determine whether to publish VHD blobs feat: add dedicated pipeline variable to determine whether to publish VHD blobs Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants