Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Semperis DSP solution #11656

Merged
merged 10 commits into from
Feb 3, 2025

Conversation

lilacham
Copy link
Contributor

Required items, please complete

Change(s):

  • Update Analytics Rules queries
  • Update Workbooks queries
  • Update Connectors data
  • Update parser

Reason for Change(s):

  • New connectors were added

Version Updated:

  • Yes

Testing Completed:

  • Yes

@lilacham lilacham requested review from a team as code owners January 13, 2025 08:20
@v-prasadboke v-prasadboke self-assigned this Jan 13, 2025
@v-prasadboke v-prasadboke added Connector Connector specialty review needed Solution Solution specialty review needed labels Jan 13, 2025
@lilacham
Copy link
Contributor Author

lilacham commented Jan 13, 2025 via email

@lilacham
Copy link
Contributor Author

lilacham commented Jan 13, 2025 via email

@v-prasadboke v-prasadboke requested a review from a team as a code owner January 28, 2025 13:23
@v-prasadboke
Copy link
Contributor

Hello @lilacham everything looks good.
Preview images mentioned in workbook metadata are missing. Please add those in images folder of workbooks.

@lilacham
Copy link
Contributor Author

Hi @v-prasadboke

Thank you for your feedback.

I checked the error and confirmed that the files are in the correct folder (Solutions\Semperis Directory Services Protector\Workbooks\Images\Preview). Please verify that your webhook (pipeline) is valid.

Let me know if there’s anything else I can assist with.

@v-prasadboke
Copy link
Contributor

Looks good

@rahul0216 rahul0216 merged commit 1838656 into Azure:master Feb 3, 2025
33 of 34 checks passed
@lilacham lilacham deleted the update_semperis_dsp_solution branch February 3, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants