Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Diag Setting category for Cosmos DB #1425

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Sep 19, 2023

Overview/Summary

Added missing log category TableApiRequests to the diagnostic settings for Cosmos DB policy.

Address GH Issue: #1420

This PR fixes/adds/changes/removes

  1. Updated Deploy-Diagnostics-CosmosDB

Breaking Changes

  1. N/A

Testing Evidence

image

Testing URLs

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added policy Area: Diagnostic Settings PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Sep 19, 2023
@Springstone Springstone reopened this Sep 19, 2023
@github-actions github-actions bot requested a review from a team as a code owner September 19, 2023 09:42
@Springstone Springstone reopened this Sep 19, 2023
@Springstone Springstone temporarily deployed to csu-rw September 19, 2023 09:47 — with GitHub Actions Inactive
@Springstone Springstone added this to the policy-refresh-fy24-q1 milestone Sep 19, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 18f3c43 into Azure:policy-refresh-q1fy24 Sep 20, 2023
@Springstone Springstone deleted the Bug1420 branch September 20, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Diagnostic Settings policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants