Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document describing Policy Testing concept #1480

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

Springstone
Copy link
Member

Overview/Summary

Add document describing Policy Testing concept

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added the documentation Improvements or additions to documentation label Nov 24, 2023
Copy link
Contributor

@paulgrimley paulgrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Springstone LGTM from a high level read and very valuable addition based on requests to understand this further from the community

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nit picks

docs/wiki/media/ALZ Policy Assignments v2.xlsx Outdated Show resolved Hide resolved
docs/wiki/ALZ-Policies-Testing.md Show resolved Hide resolved
docs/wiki/ALZ-Policies-Testing.md Outdated Show resolved Hide resolved
docs/wiki/ALZ-Policies-Testing.md Show resolved Hide resolved
@Springstone Springstone requested a review from jtracey93 December 5, 2023 08:11
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 12c1d7c into Azure:main Dec 5, 2023
2 checks passed
@Springstone Springstone deleted the DocsPolicyTesting branch December 5, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants