Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy-Private-DNS-Zones typo for Databricks fixed #1499

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Dec 11, 2023

Overview/Summary

Addressing typo for definition reference IDs in initiative https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-Private-DNS-Zones.html for the Databricks specific private DNS zone entries.

Addresses issue #1484

This PR fixes/adds/changes/removes

  1. Fixing typo in https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-Private-DNS-Zones.html

Breaking Changes

  1. Replace me

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone changed the base branch from main to policy-refresh-q2fy24 December 11, 2023 12:19
@Springstone Springstone marked this pull request as ready for review December 13, 2023 16:45
@Springstone Springstone requested a review from a team as a code owner December 13, 2023 16:45
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Dec 13, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we tested this isnt a breaking change? e.g. needs to have assignment removed and then policy initiative updated then re-assigned?

@Springstone
Copy link
Member Author

have we tested this isnt a breaking change? e.g. needs to have assignment removed and then policy initiative updated then re-assigned?

Tested and confirmed this is not a breaking change. However, any exclusions or overrides would need to be recreated (they become invalid).

@jtracey93 jtracey93 merged commit 21b05fe into Azure:policy-refresh-q2fy24 Jan 5, 2024
1 check passed
@Springstone Springstone deleted the GH1484 branch January 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants