Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Policy/Assignment: Resource Group and Resource locations should match #1507

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Dec 14, 2023

Overview/Summary

New Policy/Assignment: Resource Group and Resource locations should match.
While there is a built-in https://www.azadvertizer.net/azpolicyadvertizer/0a914e76-4921-4c19-b460-a2d36003525a.html it is AUDIT only, and we want flexibility to DENY, which is why we're providing a custom policy.

This PR fixes/adds/changes/removes

  1. Adds new policy and assignment

Breaking Changes

  1. N/A

Testing Evidence

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone requested a review from a team as a code owner December 14, 2023 16:09
@Springstone Springstone added this to the policy-refresh-fy24-q2 milestone Dec 14, 2023
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Dec 14, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a custom policy here? The built-in doesnt have an effect parameter so we can use overrides like we do for Deny-UnmanagedDisk

@Springstone
Copy link
Member Author

Do we need a custom policy here? The built-in doesnt have an effect parameter so we can use overrides like we do for Deny-UnmanagedDisk

Good point, was on auto-pilot 🤣

@jtracey93 jtracey93 merged commit 317081f into Azure:policy-refresh-q2fy24 Dec 21, 2023
2 of 3 checks passed
@Springstone Springstone deleted the 31925 branch January 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants