Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1565: pass userAssignedIdentityResourceGroup to deployment #1566

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Feb 5, 2024

Overview/Summary

Add userAssignedIdentityResourceGroup as output for the Portal UI

This PR fixes/adds/changes/removes

  1. Bug Report: userAssignedIdentityResourceGroup is not overriden #1565

Breaking Changes

N/A

Testing Evidence

N/A

Testing URLs

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Add `userAssignedIdentityResourceGroup` as output for the Portal UI
@SvenAelterman SvenAelterman marked this pull request as ready for review February 5, 2024 19:36
@SvenAelterman SvenAelterman requested a review from a team as a code owner February 5, 2024 19:36
@SvenAelterman SvenAelterman changed the title Fix for #1565 Fix for #1565: pass userAssignedIdentityResourceGroup to deployment Feb 5, 2024
@jtracey93 jtracey93 added Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Feb 6, 2024
@jtracey93 jtracey93 closed this Feb 6, 2024
@jtracey93 jtracey93 reopened this Feb 6, 2024
@jtracey93 jtracey93 linked an issue Feb 6, 2024 that may be closed by this pull request
@jtracey93
Copy link
Collaborator

Thanks @SvenAelterman, for the issue and PR to fix. Asking @arjenhuitema to take a look and review this ASAP

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @SvenAelterman, thanks for raising the issue and really appreciate the PR with fix.

@jtracey93 jtracey93 merged commit 73f8b46 into Azure:main Feb 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: userAssignedIdentityResourceGroup is not overriden
3 participants