Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt transit update #1865

Merged

Conversation

cassiekays
Copy link
Contributor

@cassiekays cassiekays commented Dec 11, 2024

Overview/Summary

This pull request includes several updates to the deprecation and replacement of various Azure policy definitions and templates. The most important changes involve the deprecation of older policies and the introduction of new or updated policies to address breaking changes or improve functionality.

Deprecation and Replacement of Policies:

Template and Metadata Updates:

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

[Deploy To Azure](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone changed the base branch from main to policy-refresh-q2fy25 December 12, 2024 11:17
@Springstone Springstone self-requested a review December 12, 2024 11:18
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments, also please add an entry in the WhatsNew.md under Policy Refresh Q2FY25 describing the deprecation (you can search for the previous entry and do something similar).
Also, please update the initiative assignment to point to the updated file.

@cassiekays cassiekays marked this pull request as ready for review December 16, 2024 18:46
@cassiekays cassiekays requested a review from a team as a code owner December 16, 2024 18:46
Springstone

This comment was marked as outdated.

@Springstone Springstone added Test: Standard Standard portal deployment test without networking PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments and removed Needs: Author Feedback labels Jan 10, 2025
@Springstone Springstone reopened this Jan 10, 2025
@Springstone Springstone merged commit 17745a0 into Azure:policy-refresh-q2fy25 Jan 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Test: Standard Standard portal deployment test without networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants