Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coverage for mismatch prop #104

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jun 18, 2024

if there is property used but it is not included in swagger, the coverage report might skip some props
regards the property not included in swagger, there will be error message in stdout:

time="2024-06-18T05:45:48Z" level=error msg="unexpected key bulkImportConfiguration in #.properties"

coverage report:
before:

image

after:

image

@teowa teowa force-pushed the fix_coverage_mismatch_prop branch from 467a311 to 83661b6 Compare June 18, 2024 05:52
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@ms-henglu ms-henglu merged commit ffae1a1 into Azure:main Jul 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants