Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option: --generate-import-block to allow users to select whether to generate the import.tf #516

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 12, 2024

Previously, this tool by default will generate the import.tf as long as the terraform >= v1.5.0. Whilst this behavior will cause error when append to a workspace as a submodule, as the import.tf is only allowed to appear at the root module.

This PR fixes this issue by introducing a new option --generate-import-blockto allow users to select whether to generate theimport.tf`.

@magodo magodo added the bug Something isn't working label Apr 12, 2024
@magodo magodo requested a review from ms-henglu April 12, 2024 04:07
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magodo magodo merged commit f492475 into Azure:main Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants