Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cfg: Add ImportCallback to allow caller inspect import status #536

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Cfg: Add ImportCallback to allow caller inspect import status #536

merged 6 commits into from
Jul 2, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 28, 2024

Add ImportCallback in the Config to allow caller inspect import status. Though, this is not directly used by this aztfexport CLI tool, while it is for future usage.

@magodo magodo added the enhancement New feature or request label Jun 28, 2024
@magodo magodo requested a review from ms-henglu June 28, 2024 08:31
@magodo
Copy link
Collaborator Author

magodo commented Jun 28, 2024

The CI failure is due to gosec's regression securego/gosec#1105, which they will release a new version 3 months later. I tried several ways to bypass the issue, all with no luck (either no effect, or new error occurs).

ms-henglu
ms-henglu approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magodo magodo merged commit 6b18fe0 into Azure:main Jul 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-henglu ms-henglu ms-henglu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magodo @ms-henglu