-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to 2023-08-01-preview swagger changes . perimeter access rule… #7738
updated to 2023-08-01-preview swagger changes . perimeter access rule… #7738
Conversation
… changes for servicetag based rule.
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
network perimeter profile access-rule create | cmd network perimeter profile access-rule create added parameter service_tags |
||
network perimeter profile access-rule update | cmd network perimeter profile access-rule update added parameter service_tags |
Hi @bhupeshbhatt1985, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
For more info about extension versioning, please refer to Extension version schema |
@bhupeshbhatt1985 please refer to this link for correcting module version update, thanks |
@AllyW updated to [1.0.0b1] as per suggestion and understanding from the document. Bot has removed the block tag after that but ci failing . please review and suggest if this is correct or not. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
[Release] Update index.json for extension [ nsp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=168780&view=results |
@kairu-ms Please don't release it. I need to make a fix. |
Azure#7738) * updated to 2023-08-01-preview swagger changes . perimeter access rule changes for servicetag based rule. * removed the updated commands for perimeter and profile and updated history * removed NSP based rule example * fixed message * fixed servicetag example * update test recordings * update api version * fixed failing tests * added tests for service tag * updated version , 0.4.0 from 0.3.0 as new apiversion added * isExperimental to isPreview * updated release version * updated version to 1.0.0b1 * text formatting in hostory file --------- Co-authored-by: Bhupesh Bhatt <[email protected]>
Description:
Added support for service tag based perimeter access rule.
Swagger updated to 2023-08-01-preview swagger changes . a
This checklist is used to make sure that common guidelines for a pull request are followed.
aaz PR: Azure/aaz#507
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.