Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config patch to ignore payload from get #7750

Merged
merged 14 commits into from
Jul 9, 2024

Conversation

jamesfan1
Copy link
Member

@jamesfan1 jamesfan1 commented Jun 27, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 27, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

For more info about extension versioning, please refer to Extension version schema

@kairu-ms kairu-ms requested a review from necusjz July 1, 2024 03:03
@kairu-ms kairu-ms assigned necusjz and unassigned kairu-ms Jul 1, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 8, 2024

Please fix CI issues

@necusjz necusjz merged commit c94e379 into Azure:main Jul 9, 2024
18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 9, 2024

[Release] Update index.json for extension [ nginx ] : https://dev.azure.com/azclitools/release/_build/results?buildId=170827&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* make config patch to ignore payload from get

* fixed common

* change cli version

* fixed test

* new test recording

* new test recording

* fix test

* removed recording and added new

* new recording

* pushing no live mode

* restore

* new recording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants