Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vmware extension to 2023-09-01 API version #7757

Merged
merged 23 commits into from
Jul 10, 2024

Conversation

jonathanhe-msft
Copy link
Contributor

@jonathanhe-msft jonathanhe-msft commented Jun 28, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 28, 2024

❌Azure CLI Extensions Breaking Change Test
❌vmware
rule cmd_name rule_message suggest_message
1007 - ParaRemove vmware cluster update cmd vmware cluster update removed parameter sku please add back parameter sku for cmd vmware cluster update
1006 - ParaAdd vmware datastore netapp-volume create cmd vmware datastore netapp-volume create added parameter net_app_volume please remove parameter net_app_volume for cmd vmware datastore netapp-volume create
1007 - ParaRemove vmware datastore netapp-volume create cmd vmware datastore netapp-volume create removed parameter net_app_volumn please add back parameter net_app_volumn for cmd vmware datastore netapp-volume create
1006 - ParaAdd vmware private-cloud rotate-nsxt-password cmd vmware private-cloud rotate-nsxt-password added parameter private_cloud please remove parameter private_cloud for cmd vmware private-cloud rotate-nsxt-password
1006 - ParaAdd vmware private-cloud rotate-nsxt-password cmd vmware private-cloud rotate-nsxt-password added parameter resource_group please remove parameter resource_group for cmd vmware private-cloud rotate-nsxt-password
⚠️ 1009 - ParaPropRemove vmware cloud-link create cmd vmware cloud-link create update parameter linked_cloud: removed property required=True
⚠️ 1001 - CmdAdd vmware cloud-link wait cmd vmware cloud-link wait added
⚠️ 1006 - ParaAdd vmware cluster create cmd vmware cluster create added parameter vsan_datastore_name
⚠️ 1006 - ParaAdd vmware cluster update cmd vmware cluster update added parameter vsan_datastore_name
⚠️ 1011 - SubgroupAdd vmware datastore elastic-san-volume sub group vmware datastore elastic-san-volume added
⚠️ 1011 - SubgroupAdd vmware iscsi-path sub group vmware iscsi-path added
⚠️ 1006 - ParaAdd vmware private-cloud create cmd vmware private-cloud create added parameter virtual_network_id
⚠️ 1009 - ParaPropRemove vmware private-cloud create cmd vmware private-cloud create update parameter cluster_size: removed property required=True
⚠️ 1009 - ParaPropRemove vmware private-cloud create cmd vmware private-cloud create update parameter network_block: removed property required=True
⚠️ 1006 - ParaAdd vmware private-cloud rotate-nsxt-password cmd vmware private-cloud rotate-nsxt-password added parameter no_wait
⚠️ 1006 - ParaAdd vmware private-cloud rotate-nsxt-password cmd vmware private-cloud rotate-nsxt-password added parameter yes
⚠️ 1006 - ParaAdd vmware private-cloud update cmd vmware private-cloud update added parameter dns_zone_type
⚠️ 1006 - ParaAdd vmware private-cloud update cmd vmware private-cloud update added parameter hosts
⚠️ 1006 - ParaAdd vmware private-cloud update cmd vmware private-cloud update added parameter network_block
⚠️ 1006 - ParaAdd vmware private-cloud update cmd vmware private-cloud update added parameter vsan_datastore_name
⚠️ 1006 - ParaAdd vmware script-execution create cmd vmware script-execution create added parameter yes

Copy link

Hi @jonathanhe-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 28, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@jonathanhe-msft jonathanhe-msft changed the title Jonathanhe/api upgrade Upgrade vmware extension to 2023-03-01 API version Jun 28, 2024
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

For more info about extension versioning, please refer to Extension version schema

@jonathanhe-msft
Copy link
Contributor Author

@kairu-ms can you review this PR? would like to have it included in the next CLI release

@yonzhan yonzhan requested a review from yanzhudd June 28, 2024 23:01
@jonathanhe-msft jonathanhe-msft changed the title Upgrade vmware extension to 2023-03-01 API version Upgrade vmware extension to 2023-09-01 API version Jul 2, 2024
@yanzhudd yanzhudd merged commit 8977f76 into Azure:main Jul 10, 2024
17 of 18 checks passed
liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
@azclibot
Copy link
Collaborator

azclibot commented Aug 1, 2024

[Release] Update index.json for extension [ vmware ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177827&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants