Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] az storage account task-assignment: Add task assignment preview, mark storage account migration as GA #7774

Merged

Conversation

calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Jul 3, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Jul 3, 2024
Copy link

azure-client-tools-bot-prd bot commented Jul 3, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️storage-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd storage account task-assignment sub group storage account task-assignment added

Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @calvinhzy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 3, 2024

Storage

Copy link

github-actions bot commented Jul 3, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jul 3, 2024

For more info about extension versioning, please refer to Extension version schema

@calvinhzy calvinhzy changed the title [Storage] az storage account task-assignment: Add task assignment preview, remove storage account migration as it is already GA in main repo [Storage] az storage account task-assignment: Add task assignment preview Jul 3, 2024
@calvinhzy calvinhzy changed the title [Storage] az storage account task-assignment: Add task assignment preview [Storage] az storage account task-assignment: Add task assignment preview, mark storage account migration as GA Jul 3, 2024
@calvinhzy
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@calvinhzy calvinhzy marked this pull request as ready for review July 15, 2024 08:07
@necusjz
Copy link
Member

necusjz commented Jul 15, 2024

do we need to modify setup.py?

@calvinhzy
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

…ment-preview-2023-05-01

# Conflicts:
#	src/storage-preview/HISTORY.rst
#	src/storage-preview/azext_storage_preview/commands.py
#	src/storage-preview/azext_storage_preview/tests/latest/test_storage_account_scenarios.py
@calvinhzy calvinhzy merged commit 53bef02 into Azure:main Jul 16, 2024
18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ storage-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=172660&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants