Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containerapp] Support debug console #7945

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

fangjian0423
Copy link
Contributor

Feature doc: https://github.com/serverless-paas-balam/k4apps/discussions/4846

Some cases:

az containerapp debug --name {containerappname} --resource-group {rg}
az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name}
az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name} --replica {replica_name}
az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name} --replica {replica_name} --container {container_name}

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 4, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd containerapp debug cmd containerapp debug added

Copy link

Hi @fangjian0423,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 4, 2024

Containerapp

@fangjian0423
Copy link
Contributor Author

image I got this error When testing, if it is expected, please provide a friendly message to guide the user.

we have a discussion here: #7945 (comment)

@Greedygre
Copy link
Contributor

The PR LGTM, left mini comment.
Please don't merge this PR until the feature ready for all subscription.

@Greedygre
Copy link
Contributor

For containerapp in connected environment, if does not support, please give a friendly error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants