Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAppFiles] bump to 2024-03-01-preview #7947

Merged

Conversation

audunn
Copy link
Member

@audunn audunn commented Sep 4, 2024

Migrate from msrestazure.tools to azure.mgmt.core.tools

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 4, 2024

❌Azure CLI Extensions Breaking Change Test
❌netappfiles-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove netappfiles account backup-vault backup update cmd netappfiles account backup-vault backup update removed parameter use_existing_snapshot please add back parameter use_existing_snapshot for cmd netappfiles account backup-vault backup update
1007 - ParaRemove netappfiles volume create cmd netappfiles volume create removed parameter backup_enabled please add back parameter backup_enabled for cmd netappfiles volume create
1007 - ParaRemove netappfiles volume create cmd netappfiles volume create removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume create
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter usage_threshold: updated property aaz_default from 107374182400 to 100 please change property aaz_default from 100 to 107374182400 for parameter usage_threshold of cmd netappfiles volume create
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter usage_threshold: updated property default from 107374182400 to 100 please change property default from 100 to 107374182400 for parameter usage_threshold of cmd netappfiles volume create
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter backup_enabled please add back parameter backup_enabled for cmd netappfiles volume update
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter remote_volume_resource_id please add back parameter remote_volume_resource_id for cmd netappfiles volume update
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume update
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup create cmd netappfiles account backup-vault backup create update parameter backup_name: updated property options from ['--backup-name', '--name', '-n'] to ['--backup-name', '--name', '-b', '-n']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup create cmd netappfiles account backup-vault backup create update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup delete cmd netappfiles account backup-vault backup delete update parameter backup_name: updated property options from ['--backup-name', '--name', '-n'] to ['--backup-name', '--name', '-b', '-n']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup delete cmd netappfiles account backup-vault backup delete update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup list cmd netappfiles account backup-vault backup list update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup restore-file cmd netappfiles account backup-vault backup restore-file update parameter backup_name: updated property options from ['--backup-name'] to ['--backup-name', '-b']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup restore-file cmd netappfiles account backup-vault backup restore-file update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup show cmd netappfiles account backup-vault backup show update parameter backup_name: updated property options from ['--backup-name', '--name', '-n'] to ['--backup-name', '--name', '-b', '-n']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup show cmd netappfiles account backup-vault backup show update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup update cmd netappfiles account backup-vault backup update update parameter backup_name: updated property options from ['--backup-name', '--name', '-n'] to ['--backup-name', '--name', '-b', '-n']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup update cmd netappfiles account backup-vault backup update update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup wait cmd netappfiles account backup-vault backup wait update parameter backup_name: updated property options from ['--backup-name', '--name', '-n'] to ['--backup-name', '--name', '-b', '-n']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault backup wait cmd netappfiles account backup-vault backup wait update parameter backup_vault_name: updated property options from ['--backup-vault-name'] to ['--backup-vault-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault create cmd netappfiles account backup-vault create update parameter backup_vault_name: updated property options from ['--backup-vault-name', '--name', '-n'] to ['--backup-vault-name', '--name', '-n', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault delete cmd netappfiles account backup-vault delete update parameter backup_vault_name: updated property options from ['--backup-vault-name', '--name', '-n'] to ['--backup-vault-name', '--name', '-n', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault show cmd netappfiles account backup-vault show update parameter backup_vault_name: updated property options from ['--backup-vault-name', '--name', '-n'] to ['--backup-vault-name', '--name', '-n', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault update cmd netappfiles account backup-vault update update parameter backup_vault_name: updated property options from ['--backup-vault-name', '--name', '-n'] to ['--backup-vault-name', '--name', '-n', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles account backup-vault wait cmd netappfiles account backup-vault wait update parameter backup_vault_name: updated property options from ['--backup-vault-name', '--name', '-n'] to ['--backup-vault-name', '--name', '-n', '-v']
⚠️ 1001 - CmdAdd netappfiles account create cmd netappfiles account create added
⚠️ 1001 - CmdAdd netappfiles account delete cmd netappfiles account delete added
⚠️ 1001 - CmdAdd netappfiles account list cmd netappfiles account list added
⚠️ 1001 - CmdAdd netappfiles account migrate-backup cmd netappfiles account migrate-backup added
⚠️ 1001 - CmdAdd netappfiles account renew-credentials cmd netappfiles account renew-credentials added
⚠️ 1001 - CmdAdd netappfiles account show cmd netappfiles account show added
⚠️ 1001 - CmdAdd netappfiles account update cmd netappfiles account update added
⚠️ 1001 - CmdAdd netappfiles account wait cmd netappfiles account wait added
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter accept_grow_capacity_pool_for_short_term_clone_split
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter allowed_clients
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter chown_mode
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter cifs
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter cool_access_retrieval_policy
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter has_root_access
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_i_read_only
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_i_read_write
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_p_read_only
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_p_read_write
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_read_only
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter kerberos5_read_write
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter language
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter remote_path
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter rule_index
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter unix_read_only
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter unix_read_write
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter is_default_quota_enabled: updated property options from ['--default-quota-enabled', '--is-default-quota-enabled'] to ['--default-quota-enabled', '--is-def-quota-enabled', '--is-default-quota-enabled']
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-ca', '--smb-continuously-available', '--smb-continuously-avl']
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property aaz_default=default
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property default=default
⚠️ 1009 - ParaPropRemove netappfiles volume create cmd netappfiles volume create update parameter subnet_id: removed property required=True
⚠️ 1009 - ParaPropRemove netappfiles volume create cmd netappfiles volume create update parameter unix_permissions: removed property aaz_default=0770
⚠️ 1009 - ParaPropRemove netappfiles volume create cmd netappfiles volume create update parameter unix_permissions: removed property default=0770
⚠️ 1001 - CmdAdd netappfiles volume delete cmd netappfiles volume delete added
⚠️ 1010 - ParaPropUpdate netappfiles volume latest-backup-status current show cmd netappfiles volume latest-backup-status current show update parameter volume_name: updated property options from ['--volume-name'] to ['--volume-name', '-v']
⚠️ 1010 - ParaPropUpdate netappfiles volume migrate-backup cmd netappfiles volume migrate-backup update parameter volume_name: updated property options from ['--volume-name'] to ['--volume-name', '-v']
⚠️ 1006 - ParaAdd netappfiles volume update cmd netappfiles volume update added parameter cool_access_retrieval_policy
⚠️ 1006 - ParaAdd netappfiles volume update cmd netappfiles volume update added parameter language
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter is_default_quota_enabled: updated property options from ['--default-quota-enabled', '--is-default-quota-enabled'] to ['--default-quota-enabled', '--is-def-quota-enabled', '--is-default-quota-enabled']
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter network_features: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Basic_Standard', 'Standard', 'Standard_Basic']
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-ca', '--smb-continuously-available', '--smb-continuously-avl']

Copy link

Hi @audunn,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 4, 2024

NetAppFiles

Copy link

github-actions bot commented Sep 4, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 4, 2024

@audunn audunn changed the title [NetAppFiles] bump to 2024-03-01 [NetAppFiles] bump to 2024-03-01-preview Sep 4, 2024
@audunn
Copy link
Member Author

audunn commented Sep 9, 2024

@AllyW updated

@audunn
Copy link
Member Author

audunn commented Sep 9, 2024

aaz Azure/aaz#560

@kairu-ms
Copy link
Contributor

@audunn, please verify the above breaking change are expected and write then in the release note. Thanks.

@audunn
Copy link
Member Author

audunn commented Sep 12, 2024

@kairu-ms History updated.
This should also satisfy the requrement to drop msrestazure dependency from CLI extensions. Is there specific confirmation of this needed ?

https://microsoft.sharepoint.com/:x:/t/AzureCLITools237/ETrztIl6PXhMpt22vr_5aSoBl7vdAq8lXRocPJhelkUPxA?e=ETZxaJ&CID=BE6A6F46-D970-4795-BE7C-B8692DB941ED&wdLOR=cA301C305-6C4B-43FB-B162-8B01A95B8FAE

@@ -2,6 +2,18 @@

Release History
===============
1.0.0b2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are no release notes for 1.0.0b1.

Copy link
Member Author

@audunn audunn Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsntcy You mean the previous version? Do we need to add notes for that here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the history for 1.0.0b1 in later PRs

@kairu-ms kairu-ms merged commit 28021a4 into Azure:main Sep 20, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ netappfiles-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=191103&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants