Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift tools and initial changes for networkfabric 2024-02-15-preview APIs #8286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nafizhaider32
Copy link

@nafizhaider32 nafizhaider32 commented Nov 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Linked to #626

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @nafizhaider32,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @nafizhaider32,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @nafizhaider32

⚠️ Release Requirements

Module: managednetworkfabric

  • ⚠️ Please update VERSION to be 7.0.0 in src/managednetworkfabric/setup.py
  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for managednetworkfabric

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 14, 2024
@yonzhan yonzhan requested a review from jsntcy November 14, 2024 23:14
@nafizhaider32 nafizhaider32 changed the title Uplift tools and initial changes for api version 2024-02-15-preview #626 Uplift tools and initial changes for networkfabric 2024-02-15-preview APIs Nov 15, 2024
@nafizhaider32 nafizhaider32 marked this pull request as draft November 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants