-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network] az network virtual-appliance inbound-security-rule
: Support of GET operation for NVA Inbound Security Rule
#29223
Merged
necusjz
merged 1 commit into
Azure:dev
from
ashutmi:get_inbound_sec_rule_operation_change
Jun 25, 2024
Merged
[Network] az network virtual-appliance inbound-security-rule
: Support of GET operation for NVA Inbound Security Rule
#29223
necusjz
merged 1 commit into
Azure:dev
from
ashutmi:get_inbound_sec_rule_operation_change
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutmi
requested review from
jsntcy,
kairu-ms,
wangzelin007 and
necusjz
as code owners
June 21, 2024 13:46
️✔️AzureCLI-FullTest
|
Hi @ashutmi, |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
network virtual-appliance inbound-security-rule show | cmd network virtual-appliance inbound-security-rule show added |
Network |
microsoft-github-policy-service
bot
added
the
Network
az network vnet/lb/nic/dns/etc...
label
Jun 21, 2024
ashutmi
changed the title
[Network] az network virtual-appliance inbound-security-rule: Support of GET operation for NVA Inbound Security Rule
[Network] az network virtual-appliance inbound-security-rule : Support of GET operation for NVA Inbound Security Rule
Jun 21, 2024
ashutmi
changed the title
[Network] az network virtual-appliance inbound-security-rule : Support of GET operation for NVA Inbound Security Rule
[Network] Jun 21, 2024
az network virtual-appliance inbound-security-rule
: Support of GET operation for NVA Inbound Security Rule
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
ashutmi
changed the title
[Network]
[Network] Jun 24, 2024
az network virtual-appliance inbound-security-rule
: Support of GET operation for NVA Inbound Security Ruleaz network virtual-appliance inbound-security-rule
: Support of GET operation for NVA Inbound Security Rule
/azp run |
Commenter does not have sufficient privileges for PR 29223 in repo Azure/azure-cli |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
network virtual-appliance inbound-security-rule show
Description
Added Support of GET Operation for Network Virtual Appliance Inbound Security Rule
Testing Case
GET an existing Inbound Security Rule Command:
az network virtual-appliance inbound-security-rule show --nva-name "storageTest3" -g "AshuSneaky" --subscription 62364504-2406-418e-971c-05822ff72fad --name "RulePermant"
Expected Output:
{ "etag": "92c48608-9147-4658-a93d-61b9b71fb6ae", "id": "/subscriptions/62364504-2406-418e-971c-05822ff72fad/resourceGroups/AshuSneaky/providers/Microsoft.Network/networkVirtualAppliances/storageTest3/inboundSecurityRules/RulePermant", "name": "RulePermant", "provisioningState": "Failed", "resourceGroup": "AshuSneaky", "ruleType": "Permanent", "rules": [ { "appliesOn": [ "slbip" ], "destinationPortRanges": [ "81-91" ], "name": "inbound", "protocol": "TCP", "sourceAddressPrefix": "0.0.0.0/0" } ], "type": "Microsoft.Network/NetworkVirtualAppliances/InboundSecurityRules" }
Help Command:
az network virtual-appliance inbound-security-rule show --help
Output:
Associated documentation (AAZ) PR: Azure/aaz#505
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.