{Lab} Migrate az lab to AAZ
#29878
Merged
{Lab} Migrate az lab to AAZ
#29878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
requested review from
jiasli,
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Lab |
Please check if these breaking changes are expected. |
Fixed |
jsntcy
approved these changes
Sep 10, 2024
jiasli
reviewed
Sep 11, 2024
| try: | ||
| current_user = graph_client.signed_in_user.get() | ||
| if current_user and current_user.object_id: # pylint:disable=no-member | ||
| return current_user.object_id # pylint:disable=no-member | ||
| except CloudError: | ||
| except HttpResponseError: |
There was a problem hiding this comment.
graph_client is Track 1 SDK will never raise HttpResponseError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az labDescription
Migrate
az labto AAZAAZ model: Azure/aaz#562
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.