fetch primary mac for hns accelnet (#2857)

* fetch primary mac for hns accelnet

* downgrade winio module

* revert winio to 0.6.2

* remove replace winio old version & separate hns call into windows-only file

* fix lint errors

* rename files

* go fmt locally

* add build tags

* moving method to platform package

* refactor files to restserver
fix fmt issues, linter

* minor comment edit

* undo azure-ipam go.mod, edit minor comments

* add log line & format better main.go

* address review comments, change ctx todo

* undo temp pipeline changes

* fix: gofumpt the file linter error

cns/middlewares/k8sSwiftV2.go

@@ -228,9 +228,9 @@ func (k *K8sSWIFTv2Middleware) getIPConfig(ctx context.Context, podInfo cns.PodI
 						PrefixLength: uint8(prefixSize),
 					},
 					MacAddress:        interfaceInfo.MacAddress,
-					NICType:           cns.DelegatedVMNIC,
+					NICType:           nicType,
 					SkipDefaultRoutes: false,
-					// InterfaceName is empty for DelegatedVMNIC
+					// InterfaceName is empty for DelegatedVMNIC and AccelnetFrontendNIC
 				}
 				// for windows scenario, it is required to add additional fields with the exact subnetAddressSpace
 				// received from MTPNC, this function assigns them for windows while linux is a no-op

cns/restserver/internalapi.go

@@ -578,3 +578,7 @@ func (service *HTTPRestService) CreateOrUpdateNetworkContainerInternal(req *cns.
 
 	return returnCode
 }
+
+func (service *HTTPRestService) SetVFForAccelnetNICs() error {
+	return service.setVFForAccelnetNICs()
+}

cns/restserver/internalapi_linux.go

@@ -93,3 +93,8 @@ func (service *HTTPRestService) programSNATRules(req *cns.CreateNetworkContainer
 	}
 	return types.Success, ""
 }
+
+// no-op for linux
+func (service *HTTPRestService) setVFForAccelnetNICs() error {
+	return nil
+}

cns/restserver/internalapi_windows.go

@@ -1,11 +1,65 @@
 package restserver
 
 import (
+	"context"
+	"fmt"
+	"time"
+
 	"github.com/Azure/azure-container-networking/cns"
 	"github.com/Azure/azure-container-networking/cns/types"
+	"github.com/Microsoft/hcsshim"
+	"github.com/pkg/errors"
+)
+
+const (
+	// timeout for powershell command to return the interfaces list
+	pwshTimeout = 120 * time.Second
 )
 
 // nolint
 func (service *HTTPRestService) programSNATRules(req *cns.CreateNetworkContainerRequest) (types.ResponseCode, string) {
 	return types.Success, ""
 }
+
+// setVFForAccelnetNICs is used in SWIFTV2 mode to set VF on accelnet nics
+func (service *HTTPRestService) setVFForAccelnetNICs() error {
+	// supply the primary MAC address to HNS api
+	macAddress, err := service.getPrimaryNICMACAddress()
+	if err != nil {
+		return err
+	}
+	macAddresses := []string{macAddress}
+	if _, err := hcsshim.SetNnvManagementMacAddresses(macAddresses); err != nil {
+		return errors.Wrap(err, "Failed to set primary NIC MAC address")
+	}
+	return nil
+}
+
+// getPrimaryNICMacAddress fetches the MAC address of the primary NIC on the node.
+func (service *HTTPRestService) getPrimaryNICMACAddress() (string, error) {
+	// Create a new context and add a timeout to it
+	ctx, cancel := context.WithTimeout(context.Background(), pwshTimeout)
+	defer cancel() // The cancel should be deferred so resources are cleaned up
+
+	res, err := service.wscli.GetInterfaces(ctx)
+	if err != nil {
+		return "", fmt.Errorf("failed to find primary interface info: %w", err)
+	}
+	var macAddress string
+	for _, i := range res.Interface {
+		// skip if not primary
+		if !i.IsPrimary {
+			continue
+		}
+		// skip if no subnets
+		if len(i.IPSubnet) == 0 {
+			continue
+		}
+		macAddress = i.MacAddress
+	}
+
+	if macAddress == "" {
+		return "", errors.New("MAC address not found(empty) from wireserver")
+	}
+	return macAddress, nil
+}

cns/service/main.go

@@ -875,6 +875,12 @@ func main() {
 			if err = httpRemoteRestService.SavePnpIDMacaddressMapping(rootCtx); err != nil {
 				logger.Errorf("Failed to fetch PnpIDMacaddress mapping: %v", err)
 			}
+
+			// No-op for linux, setting primary macaddress if VF is enabled on the nics for aks swiftv2 windows
+			logger.Printf("Setting VF for accelnet nics if feature is enabled (only on windows VM & swiftV2 scenario)")
+			if err = httpRemoteRestService.SetVFForAccelnetNICs(); err != nil {
+				logger.Errorf("Failed to set VF for accelnet NICs: %v", err)
+			}
 		}
 	}