Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: ci: remove logger field from portforwarder to avoid race with goroutine (#2959) #2975

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Aug 29, 2024

  • do not pass testing logger into goroutine to avoid race

  • fix port forwarder

Reason for Change:

Backports #2959 to resolve data races in cni release test pipeline

Issue Fixed:

Requirements:

Notes:

…ne (#2959)

* do not pass testing logger into goroutine to avoid race

* fix port forwarder
@QxBytes QxBytes added cni Related to CNI. fix Fixes something. ci Infra or tooling. release/1.5 Change affects v1.5 release train labels Aug 29, 2024
@QxBytes QxBytes self-assigned this Aug 29, 2024
@QxBytes
Copy link
Contributor Author

QxBytes commented Aug 29, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes marked this pull request as ready for review August 29, 2024 19:20
@QxBytes QxBytes requested a review from a team as a code owner August 29, 2024 19:20
@QxBytes QxBytes enabled auto-merge August 29, 2024 19:20
@QxBytes QxBytes disabled auto-merge August 29, 2024 19:34
@QxBytes QxBytes enabled auto-merge August 29, 2024 19:34
@QxBytes
Copy link
Contributor Author

QxBytes commented Aug 30, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@QxBytes QxBytes added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 4, 2024
@QxBytes QxBytes added this pull request to the merge queue Sep 4, 2024
Merged via the queue into release/v1.5 with commit 609e6ee Sep 5, 2024
270 of 273 checks passed
@QxBytes QxBytes deleted the alew/backport-portforward-race-fix branch September 5, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. cni Related to CNI. fix Fixes something. release/1.5 Change affects v1.5 release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants