fix: route issues on Swiftv2 Windows #3205
Open
+185
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
defaultroutelongtermsolution
branch
2 times, most recently
from
6683000 to
ec4f810
Compare
paulyufan2
force-pushed
the
defaultroutelongtermsolution
branch
from
cd29e26 to
8077cd5
Compare
paulyufan2
changed the title
paulyufan2
changed the title
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
paulyufan2
force-pushed
the
defaultroutelongtermsolution
branch
from
6b3eefc to
0213526
Compare
paulyufan2
force-pushed
the
defaultroutelongtermsolution
branch
4 times, most recently
from
1249211 to
272f829
Compare
kmurudi
reviewed
Jan 15, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
force-pushed
the
defaultroutelongtermsolution
branch
from
e9442c3 to
4f8ef4f
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timraymond
reviewed
Jan 23, 2025
| for i := range podIPInfo { | ||
| assert.DeepEqual(t, podIPInfo[i].Routes, desiredPodIPInfo[i].Routes) | ||
| reflect.DeepEqual(podIPInfo[i].Routes, desiredPodIPInfo[i].Routes) |
There was a problem hiding this comment.
Preference towards github.com/google/go-cmp/cmp.Equal over reflect.DeepEqual (it's a drop-in replacement)
Comment on lines
+277
to
+278
| v4IPs = []string{} | ||
| v6IPs = []string{} |
There was a problem hiding this comment.
Don't use named returns please, they have surprising semantics. For example, these two lines are unnecessary since they are auto-initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This is the long term solution to fix Swiftv2 Windows Routes issues to make sure windows cns gets all required cidrs from AKS.
Fixes include:
1.Windows CNS gets infravnet/pod/node cidrs from configs
2.Add these routes and send them to the CNI
Issue Fixed:
Background of the issue:
In Linux Swiftv2, CNS fetches infravnet/pod/node cidrs from the node's envs set by AKS; we should do same thing for Windows;
Requirements:
Require to validate this PR after AKS-RP PR to be merged
Notes: