Skip to content

Commit

Permalink
fix: InstancePoolApiClient.List throws System.Text.Json.JsonException
Browse files Browse the repository at this point in the history
  • Loading branch information
memoryz committed Mar 8, 2024
1 parent f5f997c commit 80fb957
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion csharp/Microsoft.Azure.Databricks.Client/DbfsApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public async Task<IEnumerable<FileInfo>> List(string path, CancellationToken can
var url = $"{ApiVersion}/dbfs/list?path={encodedPath}";
var result = await HttpGet<JsonObject>(this.HttpClient, url, cancellationToken).ConfigureAwait(false);
return result.TryGetPropertyValue("files", out var files)
? files.Deserialize<IEnumerable<FileInfo>>()
? files.Deserialize<IEnumerable<FileInfo>>(Options)
: Enumerable.Empty<FileInfo>();
}

Expand Down
6 changes: 3 additions & 3 deletions csharp/Microsoft.Azure.Databricks.Client/GroupsApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public async Task<IEnumerable<PrincipalName>> ListMembers(string groupName,
var response = await HttpGet<JsonObject>(this.HttpClient, url, cancellationToken).ConfigureAwait(false);

return response.TryGetPropertyValue("members", out var members)
? members.Deserialize<IEnumerable<PrincipalName>>()
? members.Deserialize<IEnumerable<PrincipalName>>(Options)
: Enumerable.Empty<PrincipalName>();
}

Expand All @@ -56,7 +56,7 @@ public async Task<IEnumerable<string>> List(CancellationToken cancellationToken
var response = await HttpGet<JsonObject>(this.HttpClient, $"{ApiVersion}/groups/list", cancellationToken)
.ConfigureAwait(false);
return response.TryGetPropertyValue("group_names", out var groupNames)
? groupNames.Deserialize<IEnumerable<string>>()
? groupNames.Deserialize<IEnumerable<string>>(Options)
: Enumerable.Empty<string>();
}

Expand All @@ -70,7 +70,7 @@ public async Task<IEnumerable<string>> ListParent(PrincipalName principalName,
var response = await HttpGet<JsonObject>(this.HttpClient, url, cancellationToken).ConfigureAwait(false);

return response.TryGetPropertyValue("group_names", out var groupNames)
? groupNames.Deserialize<IEnumerable<string>>()
? groupNames.Deserialize<IEnumerable<string>>(Options)
: Enumerable.Empty<string>();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public async Task<IEnumerable<InstancePoolInfo>> List(CancellationToken cancella
var requestUri = $"{ApiVersion}/instance-pools/list";
var poolList = await HttpGet<JsonObject>(this.HttpClient, requestUri, cancellationToken).ConfigureAwait(false);
return poolList.TryGetPropertyValue("instance_pools", out var instancePools)
? instancePools.Deserialize<IEnumerable<InstancePoolInfo>>()
? instancePools.Deserialize<IEnumerable<InstancePoolInfo>>(Options)
: Enumerable.Empty<InstancePoolInfo>();
}
}

0 comments on commit 80fb957

Please sign in to comment.