Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Refactor Linux container management to avoid race condition that leads the host to initialize placeholder (warmup) function #10848

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

[Bug Fix] Refactor Linux container management to avoid race condition that leads the host to initialize placeholder (warmup) function #10848

wants to merge 7 commits into from

Conversation

satvu
Copy link
Member

@satvu satvu commented Feb 13, 2025

Issue describing the changes in this PR

resolves #10725

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu requested a review from a team as a code owner February 13, 2025 20:58
@satvu satvu requested review from fabiocav and jviau February 13, 2025 21:00
jviau
jviau reviewed Feb 14, 2025
View reviewed changes
src/WebJobs.Script.WebHost/Management/IInstanceManager.cs
@@ -13,7 +13,7 @@ public interface IInstanceManager

Task<string> ValidateContext(HostAssignmentContext assignmentContext);

bool StartAssignment(HostAssignmentContext assignmentContext);
Task<bool> StartAssignment(HostAssignmentContext assignmentContext);
Copy link
Contributor

@jviau jviau Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename this. It is no longer a Start anymore with the Task. Maybe AssignInstanceAsync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau left review comments

@fabiocav fabiocav Awaiting requested review from fabiocav

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition leads the host to initialize placeholder (warmup) function in Linux environments
2 participants
@satvu @jviau