Migrate RedisEnterpriseCache from generation to main #26298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
|
Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon. |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate RedisEnterpriseCache from generation to main
The last commit of src/RedisEnterpriseCache in generation is:
commit 44e0920 Author: revanthballa1188 [email protected] Date: Sat Oct 12 13:49:32 2024 +0530 Fix upgraderedisDb cmdlet (#26142) * Add 2024-06-01-preview for redis enterprise * Update New-AzRedisEnterpriseCache.ps1 * update files aftre building modules * Add test recordings * Update examples of force unlink and upgrade db * fix SKU naming * fix examples * Fix upgrade Db cmdlet --------- Co-authored-by: Yabo Hu [email protected]
Checklist