Update dependencies and targets #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
commented
Jan 30, 2024
| uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: '3.1.x' | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
The base images have net8.0 already installed.
| @@ -0,0 +1,16 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Central package management such that version are store in a single place.
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> | ||
| <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> | ||
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> | ||
| <TargetFrameworks>net6.0</TargetFrameworks> |
There was a problem hiding this comment.
This means anything higher is fine (net7.0, net8.0, ...). It matters to target other ones only if we have custom code for it.
| <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.1.1" /> | ||
| <PackageReference Include="Microsoft.Net.Http.Headers" Version="2.1.1" /> | ||
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> |
There was a problem hiding this comment.
These packages are not published anymore (most). Referencing the shared framework is the way to go.
| using System.IO; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Text.Json; |
There was a problem hiding this comment.
Removed NewtonSoft.Json dependency.
| @@ -1,17 +1,11 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>$(StandardTestTfms)</TargetFrameworks> | |||
| <TargetFrameworks>net6.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Tests are executed on both.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Microsoft.Azure.Relay.AspNetCore\Microsoft.Azure.Relay.AspNetCore.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.Net.Http.WinHttpHandler" Version="4.5.4" /> |
There was a problem hiding this comment.
Not needed anymore and cross-platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some transitive dependencies have vulnerabilities, and this is an attempt to refresh those and upgrade to supported framework versions.