Skip to content

Commit

Permalink
Disable default features in libxml2. (#5221)
Browse files Browse the repository at this point in the history
* Disable default features in libxml2.
We don't seem to make use of any of them in `xml_wrapper.cpp`.

* Update changelog.

* Added "Acknowledgments" section to the Storage Changelog.

* "Identity" => "Storage" (my bad)

* Apply suggestions from code review

Co-authored-by: Anton Kolesnyk <[email protected]>

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
  • Loading branch information
teo-tsirpanis and antkmsft authored Dec 12, 2023
1 parent 818d227 commit 2dbaa8a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
8 changes: 8 additions & 0 deletions sdk/storage/azure-storage-common/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,20 @@

### Features Added

- Removed unnecessary dependencies on non-Windows platforms. (A community contribution, courtesy of _[teo-tsirpanis](https://github.com/teo-tsirpanis)_)

### Breaking Changes

### Bugs Fixed

### Other Changes

### Acknowledgments

Thank you to our developer community members who helped to make Azure Storage better with their contributions to this release:

- Theodore Tsirpanis _([GitHub](https://github.com/teo-tsirpanis))_

## 12.5.0 (2023-11-07)

### Features Added
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-common/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"azure-core-cpp",
{
"name": "libxml2",
"default-features": false,
"platform": "!windows"
},
{
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-common/vcpkg/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
},
{
"name": "libxml2",
"default-features": false,
"platform": "!windows"
},
{
Expand Down
1 change: 1 addition & 0 deletions vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
},
{
"name": "libxml2",
"default-features": false,
"platform": "!windows & !uwp"
},
{
Expand Down

0 comments on commit 2dbaa8a

Please sign in to comment.