[keyvault] add cae support #23543
Open
[keyvault] add cae support #23543
+167
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewilcox
added
KeyVault
Client
chlowell
reviewed
Oct 4, 2024
chlowell
reviewed
Oct 14, 2024
| default: | ||
| t.Fatal("unexpected token request") | ||
| } | ||
| return azcore.AccessToken{Token: accessTk, ExpiresOn: time.Now().Add(time.Hour)}, nil |
There was a problem hiding this comment.
Can you please also check that the policy uses the correct access token after handling the CAE challenge? Something simple like this should do in the credential:
Suggested change
| return azcore.AccessToken{Token: accessTk, ExpiresOn: time.Now().Add(time.Hour)}, nil | |
| return azcore.AccessToken{Token: fmt.Sprint(tkReqs), ExpiresOn: time.Now().Add(time.Hour)}, nil |
...then a predicate in the AppendResponse calls can compare the actual value of the Authorization header
Comment on lines
+104
to
+105
| accessTk = "***" | ||
| kvChallenge = `Bearer authorization="https://login.microsoftonline.com/tenant", resource="https://vault.azure.net"` |
There was a problem hiding this comment.
Consider sharing these constants with the test above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Azure/azure-sdk-for-go-pr/issues/43
Adding CAE support to key vault libraries: