-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage][DataMovement] Refactor resource provider credential callbacks #47984
Merged
jalauzon-msft
merged 12 commits into
Azure:main
from
jalauzon-msft:refactor-provider-delegates
Jan 27, 2025
Merged
[Storage][DataMovement] Refactor resource provider credential callbacks #47984
jalauzon-msft
merged 12 commits into
Azure:main
from
jalauzon-msft:refactor-provider-delegates
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalauzon-msft
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft and
nickliu-msft
as code owners
January 25, 2025 00:08
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Storage.DataMovement.Blobs |
amnguye
reviewed
Jan 27, 2025
...rage/Azure.Storage.DataMovement.Blobs/api/Azure.Storage.DataMovement.Blobs.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
amnguye
reviewed
Jan 27, 2025
...zure.Storage.DataMovement.Files.Shares/api/Azure.Storage.DataMovement.Files.Shares.net6.0.cs
Outdated
Show resolved
Hide resolved
amnguye
reviewed
Jan 27, 2025
sdk/storage/Azure.Storage.DataMovement.Blobs/src/BlobsStorageResourceProvider.cs
Outdated
Show resolved
Hide resolved
amnguye
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - had a nit picky comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes refactoring the credential callbacks for the
BlobStorageResourceProvider
andFileShareStorageResourceProvider
and additional supporting changes.