-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure sdk support for network acls #38511
Open
mohitsinghnegi2
wants to merge
19
commits into
Azure:main
Choose a base branch
from
mohitsinghnegi2:azure-sdk-support-for-networkAcls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Azure sdk support for network acls #38511
mohitsinghnegi2
wants to merge
19
commits into
Azure:main
from
mohitsinghnegi2:azure-sdk-support-for-networkAcls
+293
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into azure-sdk-support-for-networkAcls Pulled latest changes from master
mohitsinghnegi2
requested review from
seanyao1,
debuggerXi,
kingernupur,
achauhan-scc and
paulshealy1
as code owners
November 13, 2024 12:16
@microsoft-github-policy-service agree company="Microsoft" |
API change check APIView has identified API level changes in this PR and created following API reviews. |
…into azure-sdk-support-for-networkAcls pull main branch changes
…into azure-sdk-support-for-networkAcls
…into azure-sdk-support-for-networkAcls merge branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the ML Default Workspace and AI Studio Hub Workspace offer two network access options: All Network and Disable This PR introduces a third option i.e. Enabled from selected IP addresses, using new field called network ACLs (Network Access Control Lists) in Workspace Class. This field will be use to define IP Address/ IP ranges on workspace. That would mean Only defined IP addresses/ranges would get access to the Default / Hub workspaces.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines