Bump monitor API version

[AndreiBarbuOz]

What this PR does

Update the version of the Microsoft.Insights/scheduledQueryRules to catch up with https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/change-log/scheduledqueryrules#2024-01-01-preview

The new version comes with some features, including the addition of a .spec.identity field which allows using an existing user assignment identity when the service executes the query. This was captured in a focused test, which creates the necessary prerequisites before instantiating the object.

How does this PR make you feel?

Checklist

• this PR contains tests
• this PR contains YAML Samples

[AndreiBarbuOz]

@microsoft-github-policy-service agree company="UiPath"

[super-harsh]

Looks good! Just a few minor comments below.

[super-harsh]

Looks good! Just a minor thing without which CI won't pass is that you're missing a recording for sample test. You can run TEST_FILTER=Test_Samples_CreationAndDeletion task controller:test-integration-envtest command in root which'll test your latest sample(s) and create a recording.

[matthchr]

Checking if you'd like this merged (or need help?) let us know!

[theunrepentantgeek]

We're going to publish the v2.13 release of ASO very soon and it would be good to include these in that release.

Do you think you can sort out the CI issues in the next couple of days (say, by Thursday this week)?

[theunrepentantgeek]

Did you miss committing the recordings from the tests that check the samples? CI is failing with these errors:

[produce-markdown-summary] - Test failed: Test_Samples_CreationAndDeletion/Test_Insights_v1api20220615_CreationAndDeletion
[produce-markdown-summary] === TEST OUTPUT ===
[produce-markdown-summary] === RUN   Test_Samples_CreationAndDeletion/Test_Insights_v1api20220615_CreationAndDeletion
[produce-markdown-summary] === PAUSE Test_Samples_CreationAndDeletion/Test_Insights_v1api20220615_CreationAndDeletion
[produce-markdown-summary] === CONT  Test_Samples_CreationAndDeletion/Test_Insights_v1api20220615_CreationAndDeletion
[produce-markdown-summary]     kube_per_test_context.go:167: creating recorder: required environment variable "AZURE_SUBSCRIPTION_ID" was not supplied
[produce-markdown-summary] --- FAIL: Test_Samples_CreationAndDeletion/Test_Insights_v1api20220615_CreationAndDeletion (0.00s)
[produce-markdown-summary] === END TEST OUTPUT ===
[produce-markdown-summary] - Test failed: Test_Samples_CreationAndDeletion/Test_Insights_v1api20240101preview_CreationAndDeletion
[produce-markdown-summary] === TEST OUTPUT ===
[produce-markdown-summary] === RUN   Test_Samples_CreationAndDeletion/Test_Insights_v1api20240101preview_CreationAndDeletion
[produce-markdown-summary] === PAUSE Test_Samples_CreationAndDeletion/Test_Insights_v1api20240101preview_CreationAndDeletion
[produce-markdown-summary] === CONT  Test_Samples_CreationAndDeletion/Test_Insights_v1api20240101preview_CreationAndDeletion
[produce-markdown-summary]     kube_per_test_context.go:167: creating recorder: required environment variable "AZURE_SUBSCRIPTION_ID" was not supplied
[produce-markdown-summary] --- FAIL: Test_Samples_CreationAndDeletion/Test_Insights_v1api20240101preview_CreationAndDeletion (0.00s)
[produce-markdown-summary] === END TEST OUTPUT ===

This usually means missing recordings for the tests.

If that's not it, let me know and I'll investigate further by checking out your PR locally.

[petrepopescu21]

@theunrepentantgeek The tests were actually failing because of a non-retryable 400 error received when the role assignment was not ready (the samples use a managed identity).

Had to add a case to the ErrorClassifier for ScheduledQueryRuns (found your PR here) and I've since committed the test recording as well.

Please let me know if the classifier change needs to be a separate PR or if they can be merged together.

[matthchr]

Please let me know if the classifier change needs to be a separate PR or if they can be merged together.

Together should be fine.

[matthchr]

/ok-to-test sha=0125a98

[petrepopescu21]

There was a sample moved which I missed, caused a "missing recording" event.
Also, the CRUD recording had some tags on the RG. I've re-recorded the test and it should now be correct.

Sorry @matthchr for the back and forth on this

[theunrepentantgeek]

I think we're getting close to a clean build. Getting a single lint error - maybe this indicates a missing assertion?

[controller:lint] internal/controllers/crd_insights_scheduledqueryrule_20240101preview_test.go:74:2: ineffectual assignment to armId (ineffassign)
[controller:lint] 	armId := *roleAssignment.Status.Id
[controller:lint] 	^

[matthchr]

/ok-to-test sha=7e5ed65

[matthchr]

/ok-to-test sha=62123ec