Bump the go-deps group across 2 directories with 2 updates #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the go-deps group with 2 updates in the /v2 directory: [github.com/google/cel-go](https://github.com/google/cel-go) and [github.com/samber/lo](https://github.com/samber/lo). Bumps the go-deps group with 2 updates in the /v2/cmd/asoctl directory: [github.com/google/cel-go](https://github.com/google/cel-go) and [github.com/samber/lo](https://github.com/samber/lo). Updates `github.com/google/cel-go` from 0.22.1 to 0.23.2 - [Release notes](https://github.com/google/cel-go/releases) - [Commits](google/cel-go@v0.22.1...v0.23.2) Updates `github.com/samber/lo` from 1.47.0 to 1.49.1 - [Release notes](https://github.com/samber/lo/releases) - [Commits](samber/lo@v1.47.0...v1.49.1) Updates `github.com/google/cel-go` from 0.22.1 to 0.23.2 - [Release notes](https://github.com/google/cel-go/releases) - [Commits](google/cel-go@v0.22.1...v0.23.2) Updates `github.com/samber/lo` from 1.47.0 to 1.49.1 - [Release notes](https://github.com/samber/lo/releases) - [Commits](samber/lo@v1.47.0...v1.49.1) --- updated-dependencies: - dependency-name: github.com/google/cel-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/samber/lo dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/google/cel-go dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/samber/lo dependency-type: indirect update-type: version-update:semver-minor dependency-group: go-deps ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
requested review from
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
|
The issue is this:
This stems from this change in CEL: google/cel-go#1075 It is due to: where kube-apiserver purposefully breaks their complication if CEL starts supporting variadic versioning args (which it just did in 0.23.0). We import kube-apiserver via controller-runtime. I think this means that we cannot take any CEL patches until such time as kube-apiserver is updated, which it has not yet been. |
It caused the following test failure: [controller:test-cover] /go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:176:19: cannot use ext.TwoVarComprehensions (value of type func(options ...ext.TwoVarComprehensionsOption) "github.com/google/cel-go/cel".EnvOption) as func() "github.com/google/cel-go/cel".EnvOption value in argument to UnversionedLib This stems from this change in CEL: google/cel-go#1075 It is due to: https://github.com/kubernetes/apiserver/blob/master/pkg/cel/environment/base.go#L268 where kube-apiserver purposefully breaks their complication if CEL starts supporting variadic versioning args (which it just did in 0.23.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the go-deps group with 2 updates in the /v2 directory: github.com/google/cel-go and github.com/samber/lo.
Bumps the go-deps group with 2 updates in the /v2/cmd/asoctl directory: github.com/google/cel-go and github.com/samber/lo.
Updates
github.com/google/cel-gofrom 0.22.1 to 0.23.2Release notes
Sourced from github.com/google/cel-go's releases.
... (truncated)
Commits
1bf2472Minor update on cost order (#1119)fb3fe56Bump github.com/golang/glog (#1115)d8351dfModify cost updates to be more extension friendly (#1113)2f7606aCost tracking for two-variable comprehensions and bindings (#1104)7621362Add optional.unwrap() / .unwrapOpt() function (#1103)9f925d8Bump the npm_and_yarn group across 1 directory with 2 updates (#1110)91fb306Update PruneAst to support constants of optional type (#1109)33a7f97Default enable using hidden accumulator name. (#1099)ee426f4Add base_config and partial_config files under restricted_destination testdat...43bc483Add test cases forstring.formatcovering various edge cases (#1101)Updates
github.com/samber/lofrom 1.47.0 to 1.49.1Release notes
Sourced from github.com/samber/lo's releases.
... (truncated)
Commits
bc6d6e8bump v1.49.196d5482fix(product): fix empty slice behavior (#583) (#584)2bdcacadoc: add example for Product and ProductBy1c1dfd9feat: add Product and ProductBy functions (#566)124d300feat: adding FilterSliceToMap (#581)19d8355Merge branch 'Lee-Minjea-feat/throttle'5cd3266feat: adding ExampleNewThrottleBy and ExampleNewThrottleByWithCountfdd8865fix: test case fixed27638eafeat: adding NewThrottle (#396)d587677feat: faster ChunkEntriesUpdates
github.com/google/cel-gofrom 0.22.1 to 0.23.2Release notes
Sourced from github.com/google/cel-go's releases.
... (truncated)
Commits
1bf2472Minor update on cost order (#1119)fb3fe56Bump github.com/golang/glog (#1115)d8351dfModify cost updates to be more extension friendly (#1113)2f7606aCost tracking for two-variable comprehensions and bindings (#1104)7621362Add optional.unwrap() / .unwrapOpt() function (#1103)9f925d8Bump the npm_and_yarn group across 1 directory with 2 updates (#1110)91fb306Update PruneAst to support constants of optional type (#1109)33a7f97Default enable using hidden accumulator name. (#1099)ee426f4Add base_config and partial_config files under restricted_destination testdat...43bc483Add test cases forstring.formatcovering various edge cases (#1101)Updates
github.com/samber/lofrom 1.47.0 to 1.49.1Release notes
Sourced from github.com/samber/lo's releases.
... (truncated)
Commits
bc6d6e8bump v1.49.196d5482fix(product): fix empty slice behavior (#583) (#584)2bdcacadoc: add example for Product and ProductBy1c1dfd9feat: add Product and ProductBy functions (#566)124d300feat: adding FilterSliceToMap (#581)19d8355Merge branch 'Lee-Minjea-feat/throttle'5cd3266feat: adding ExampleNewThrottleBy and ExampleNewThrottleByWithCountfdd8865fix: test case fixed27638eafeat: adding NewThrottle (#396)d587677feat: faster ChunkEntriesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions