Skip to content

Commit

Permalink
Fix linting issue in official build (#11215)
Browse files Browse the repository at this point in the history
###### Microsoft Reviewers:
codeflow:open?pullrequest=#11215
  • Loading branch information
shenglol authored Jul 12, 2023
1 parent 0a6612a commit 87ca110
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,13 @@ jobs:
include:
- os: windows-latest
rid: win-x64
runTests: true
- os: ubuntu-latest
rid: linux-x64
runTests: true
- os: macos-latest
rid: osx-x64
runTests: true
- os: ubuntu-latest
rid: win-arm64
runTests: false
Expand Down
12 changes: 6 additions & 6 deletions src/Bicep.MSBuild.E2eTests/src/example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ export class Example {

constructor(projectName: string, projectFile?: string) {
const projectDir = path.normalize(
path.join(__dirname, `../examples/${projectName}/`)
path.join(__dirname, `../examples/${projectName}/`),
);
this.projectDir = projectDir;
this.projectFile = path.join(
projectDir,
projectFile ?? `${projectName}.proj`
projectFile ?? `${projectName}.proj`,
);
}

Expand All @@ -42,7 +42,7 @@ export class Example {

public publish(
targetFramework: string | null,
expectSuccess = true
expectSuccess = true,
): SpawnSyncReturns<string> {
return this.runMsBuild("publish", targetFramework, expectSuccess);
}
Expand Down Expand Up @@ -76,12 +76,12 @@ export class Example {
private runMsBuild(
verb: string,
targetFramework: string | null,
expectSuccess: boolean
expectSuccess: boolean,
): SpawnSyncReturns<string> {
const runtimeSuffix = process.env.RuntimeSuffix;
if (!runtimeSuffix) {
throw new Error(
"Please set the RuntimeSuffix environment variable to a .net runtime ID to run these tests. Possible values: win-x64, linux-x64, osx-x64"
"Please set the RuntimeSuffix environment variable to a .net runtime ID to run these tests. Possible values: win-x64, linux-x64, osx-x64",
);
}
const result = spawn.sync(
Expand All @@ -98,7 +98,7 @@ export class Example {
cwd: this.projectDir,
stdio: "pipe",
encoding: "utf-8",
}
},
);

if (expectSuccess && result.status !== 0) {
Expand Down

0 comments on commit 87ca110

Please sign in to comment.