Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Min Required Tuning Memory #440

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: Add Min Required Tuning Memory #440

wants to merge 18 commits into from

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented May 29, 2024 •
edited
Loading

Reason for Change:
Begin adding minimum amount of per GPU memory required for fine-tuning

@ishaansehgal99 ishaansehgal99 changed the title feat; Add minimum required Fine-Tuning Memory feat: Add minimum required Fine-Tuning Memory May 29, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add minimum required Fine-Tuning Memory feat: Add Min Required Fine-Tuning Memory May 29, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add Min Required Fine-Tuning Memory feat: Add Min Required Tuning Memory and Update Tuning Default Params May 29, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add Min Required Tuning Memory and Update Tuning Default Params feat: Add Min Required Tuning Memory May 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 60.55%. Comparing base (ed546f0) to head (4a191d4).
Report is 12 commits behind head on main.

Files Patch % Lines
api/v1alpha1/params_validation.go 46.15% 10 Missing and 4 partials ⚠️
api/v1alpha1/workspace_validation.go 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   61.10%   60.55%   -0.55%     
==========================================
  Files          29       30       +1     
  Lines        2602     2647      +45     
==========================================
+ Hits         1590     1603      +13     
- Misses        921      948      +27     
- Partials       91       96       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ishaansehgal99