Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate constants for workspace and ragengine controller #631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
consolidate constants for workspace and ragengine controller

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 13.69863% with 63 lines in your changes missing coverage. Please review.

Project coverage is 54.49%. Comparing base (5c30038) to head (85f57e0).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/workspace_controller.go 1.66% 52 Missing and 7 partials ⚠️
api/v1alpha1/workspace_validation.go 0.00% 2 Missing ⚠️
api/v1alpha1/ragengine_validation.go 0.00% 1 Missing ⚠️
pkg/inference/preset-inferences.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   58.18%   54.49%   -3.69%     
==========================================
  Files          30       34       +4     
  Lines        2987     3257     +270     
==========================================
+ Hits         1738     1775      +37     
- Misses       1149     1376     +227     
- Partials      100      106       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhuangqh
Copy link
Member

I don't think it's necessary to replace the log key with a constant variable. you can find literal object name keys all over the kubernetes code. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+KObj&type=code&p=1

@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Oct 15, 2024

Yes, for logs, just use KObj and remove redundant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants