-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: consolidate constants for workspace and ragengine controller #631
base: main
Are you sure you want to change the base?
Conversation
585ba59
to
85f57e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
- Coverage 58.18% 54.49% -3.69%
==========================================
Files 30 34 +4
Lines 2987 3257 +270
==========================================
+ Hits 1738 1775 +37
- Misses 1149 1376 +227
- Partials 100 106 +6 ☔ View full report in Codecov by Sentry. |
I don't think it's necessary to replace the log key with a constant variable. you can find literal object name keys all over the kubernetes code. https://github.com/search?q=repo%3Akubernetes%2Fkubernetes+KObj&type=code&p=1 |
Yes, for logs, just use KObj and remove redundant information. |
85f57e0
to
1d7e1bb
Compare
1d7e1bb
to
51124c3
Compare
51124c3
to
c697541
Compare
c697541
to
fe99fd8
Compare
Signed-off-by: Bangqi Zhu <[email protected]>
fe99fd8
to
3338241
Compare
Reason for Change:
consolidate constants for workspace and ragengine controller
Requirements
Issue Fixed:
Notes for Reviewers: