feat: Update VectorStore Base class and Introduce more Integrations #649
+179
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaansehgal99
had a problem deploying
to
unit-tests
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Error
zhuangqh
reviewed
Oct 24, 2024
| index.set_index_id(index_name) | ||
| self.index_map[index_name] = index | ||
| self.index_store.add_index_struct(index.index_struct) | ||
| self._persist(index_name) |
There was a problem hiding this comment.
I am thinking about a question: will the persist fails here? or we should rollback something
There was a problem hiding this comment.
its possible, added a try-catch in persist function to help catch this
There was a problem hiding this comment.
if persist fails, should we rollback the index_store? Or there will be some inconsistencies between index_store and storage
ishaansehgal99
had a problem deploying
to
unit-tests
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Error
ishaansehgal99
changed the title
ishaansehgal99
had a problem deploying
to
unit-tests
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Error
ishaansehgal99
requested a deployment
to
unit-tests
GitHub Actions
Waiting
ishaansehgal99
requested a deployment
to
e2e-test
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cleans up vector store classes by putting common logic in the base class and inheriting from their.
With new base class also introduces two new popular integrations - azurecosmosdb mongodb, chromadb