Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run_command_enabled #452

Merged
merged 1 commit into from
Oct 30, 2023
Merged

add run_command_enabled #452

merged 1 commit into from
Oct 30, 2023

Conversation

zioproto
Copy link
Collaborator

add run_command_enabled

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#run_command_enabled

https://learn.microsoft.com/en-us/azure/aks/access-private-cluster?tabs=azure-cli

the feature is GA and it is actually enabled by default. The PR is to make possible to disable the feature.

Fixes #451

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

@zioproto zioproto temporarily deployed to acctests October 24, 2023 00:58 — with GitHub Actions Inactive
@zioproto
Copy link
Collaborator Author

@lonegunmanb or @jiaweitao001 please let me know if anything else is missing to get this one merged. Thanks !

@lonegunmanb lonegunmanb merged commit 2432c55 into Azure:main Oct 30, 2023
4 checks passed
@lonegunmanb lonegunmanb added this to the 7.5.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Support for run_command_enabled
2 participants