Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maintenance_window_auto_upgrade #505

Conversation

skolobov
Copy link
Contributor

@skolobov skolobov commented Feb 12, 2024

Describe your changes

The azurerm_kubernetes_cluster resource in the azurerm Terraform provider has variable maintenance_window_auto_upgrade - please see official documentation here

This adds support for maintenance window for automatic upgrades.

Issue number

#507

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

@skolobov skolobov force-pushed the CR-4591-add-support-for-maintenance_window_auto_upgrade branch from 7c47516 to 04a8492 Compare February 13, 2024 21:26
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skolobov for opening this pr! One review comment.

variables.tf Outdated
- `day_of_month` - (Optional) The day of the month for the maintenance run. Required in combination with RelativeMonthly frequency. Value between 0 and 31 (inclusive).
- `day_of_week` - (Optional) The day of the week for the maintenance run. Options are `Monday`, `Tuesday`, `Wednesday`, `Thurday`, `Friday`, `Saturday` and `Sunday`. Required in combination with weekly frequency.
- `duration` - (Required) The duration of the window for maintenance to run in hours.
- `frequency` - (Required) Frequency of maintenance. Possible options are `Daily`, `Weekly`, `AbsoluteMonthly` and `RelativeMonthly`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the document, possible options are Weekly, AbsoluteMonthly and RelativeMonthly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @lonegunmanb! That was my copy/paste mistake - sorry for that.
Fixed it now.

@lonegunmanb lonegunmanb added this to the 8.0.0 milestone Feb 19, 2024
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skolobov for the update, LGTM!

@lonegunmanb lonegunmanb merged commit c20b021 into Azure:main Feb 20, 2024
4 checks passed
@skolobov skolobov deleted the CR-4591-add-support-for-maintenance_window_auto_upgrade branch March 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants