-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for maintenance_window_auto_upgrade
#505
Add support for maintenance_window_auto_upgrade
#505
Conversation
docs: update README
7c47516
to
04a8492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skolobov for opening this pr! One review comment.
variables.tf
Outdated
- `day_of_month` - (Optional) The day of the month for the maintenance run. Required in combination with RelativeMonthly frequency. Value between 0 and 31 (inclusive). | ||
- `day_of_week` - (Optional) The day of the week for the maintenance run. Options are `Monday`, `Tuesday`, `Wednesday`, `Thurday`, `Friday`, `Saturday` and `Sunday`. Required in combination with weekly frequency. | ||
- `duration` - (Required) The duration of the window for maintenance to run in hours. | ||
- `frequency` - (Required) Frequency of maintenance. Possible options are `Daily`, `Weekly`, `AbsoluteMonthly` and `RelativeMonthly`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the document, possible options are Weekly
, AbsoluteMonthly
and RelativeMonthly
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @lonegunmanb! That was my copy/paste mistake - sorry for that.
Fixed it now.
…the node OS maintenance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skolobov for the update, LGTM!
Describe your changes
The
azurerm_kubernetes_cluster
resource in theazurerm
Terraform provider has variablemaintenance_window_auto_upgrade
- please see official documentation hereThis adds support for maintenance window for automatic upgrades.
Issue number
#507
Checklist before requesting a review
CHANGELOG.md
file