Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for support_plan and Premium sku tier. #508

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Add support for support_plan and Premium sku tier. #508

merged 3 commits into from
Feb 19, 2024

Conversation

ecklm
Copy link
Contributor

@ecklm ecklm commented Feb 16, 2024

Describe your changes

Make use of the premium SKU option and the support plan feature available in the azurerm provider sinve version 3.84.0.

Issue number

#477

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@ecklm
Copy link
Contributor Author

ecklm commented Feb 16, 2024

@microsoft-github-policy-service agree company="Alerant IT Ltd."

@ecklm ecklm marked this pull request as ready for review February 16, 2024 16:10
It's available through terraform-provider-azurerm since v3.84.0.

Allowed-by: hashicorp/terraform-provider-azurerm#23970
Resolves: #477
It's available through terraform-provider-azurerm since v3.84.0.

Allowed-by: hashicorp/terraform-provider-azurerm#23970
Resolves: #477
@lonegunmanb
Copy link
Member

Thanks @ecklm for opening this pr! I've checked the CHANGELOG, this feature was introduced in 3.84.0, would you please update the provider requirement in versions.tf file too? Thanks!

@ecklm
Copy link
Contributor Author

ecklm commented Feb 18, 2024

Sure. Done in c2013a2

@lonegunmanb lonegunmanb changed the title Enable premium AKS and Long Term Support configuration Add support for support_plan and Premium sku tier. Feb 19, 2024
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ecklm, LGTM!

@lonegunmanb lonegunmanb merged commit 4d0a0ff into Azure:main Feb 19, 2024
4 checks passed
@ecklm
Copy link
Contributor Author

ecklm commented Apr 17, 2024

Can this be expected in a release soon? I see it's been a year since the last one.

@zioproto
Copy link
Collaborator

Can this be expected in a release soon? I see it's been a year since the last one.

The 6.8.0 is not the latest release, for some reason GitHub is not displaying the correct information. @lonegunmanb

@ecklm 8.0.0 is the current release, check the git tag to see the release date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants