Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): typo in output variable #537

Merged
merged 3 commits into from
Jun 6, 2024
Merged

fix(typo): typo in output variable #537

merged 3 commits into from
Jun 6, 2024

Conversation

mbaykara
Copy link
Contributor

@mbaykara mbaykara commented Apr 13, 2024

Describe your changes

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@mbaykara mbaykara mentioned this pull request Apr 13, 2024
1 task
@zioproto
Copy link
Collaborator

Please run:
docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit

to auto update the README. Please follow in the README pre-commit and pr-check steps when contributing.

thanks

@mbaykara
Copy link
Contributor Author

@microsoft-github-policy-service agree

@mbaykara
Copy link
Contributor Author

mbaykara commented Apr 15, 2024

Please run: docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit

to auto update the README. Please follow in the README pre-commit and pr-check steps when contributing.

Thanks, I run the both checks respectively.

@zioproto
Copy link
Collaborator

@lonegunmanb there is a change in the output, does it need a release note in the changelog ? LGTM

@lonegunmanb
Copy link
Member

@lonegunmanb there is a change in the output, does it need a release note in the changelog ? LGTM

It's a change to the description so I think it's not a breaking change, we can just release it.

@mbaykara
Copy link
Contributor Author

mbaykara commented May 2, 2024

Is any action required from me?

@lonegunmanb
Copy link
Member

@mbaykara thanks for asking, yes, we've just fixed the failed examples so would you please rebase your pr with the latest main branch? Thanks a lot!

@mbaykara
Copy link
Contributor Author

mbaykara commented May 8, 2024

@lonegunmanb done with rerun pre-commit and pr-check.

@lonegunmanb lonegunmanb merged commit 3aaabf5 into Azure:main Jun 6, 2024
3 of 4 checks passed
@lonegunmanb
Copy link
Member

Thanks @mbaykara , LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants