Changes for Network Integration #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncoolmax
requested review from
antrix1989,
oldalton,
unpluggedk and
rohitnarula7176
oldalton
approved these changes
Jul 31, 2018
oldalton
reviewed
Jul 31, 2018
| @@ -31,7 +31,7 @@ - (id)responseObjectForResponse:(NSHTTPURLResponse *)httpResponse data:(NSData * | |||
| { | |||
| NSMutableDictionary *jsonObject = [[super responseObjectForResponse:httpResponse data:data error:error] mutableCopy]; | |||
|
|
|||
| if (error) { return nil; } | |||
| if (error && *error) { return nil; } | |||
There was a problem hiding this comment.
technically, we shouldn't expect error to be not nil and change method's behavior based on it. So, it would be better, if we added a local error variable, check for that one to return nil and only check for argument error to assign it.
unpluggedk
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSIDAADAuthorityValidationRequestMSIDAADResponseSerializer.mwhich causes nil result for json parsingmsidAddParameterswhich throws the existing parameters away